Mocking Builder in Jest

adonis17 · September 8, 2023, 3:30pm

We were using node v14 and after upgrading to v18, our Github action test started to fail. Locally they all pass.

What are you trying to accomplish
I want to make sure that locally and in the Github action all tests are passing

Screenshots

Github Action Tests

Local Tests

Code stack
Gatsby

manish-sharma · September 11, 2023, 9:01am

Hello @adonis17,

Upgrading Node.js from version 14 to version 18 in a Gatsby application can introduce several changes and potential issues, especially if your codebase and dependencies rely on specific Node.js versions or if there have been breaking changes in Node.js itself. When tests pass locally but fail in a production environment, it can be challenging to diagnose the issue because there are differences between the two environments.

The error seems to be originating from jsdom module, which could be caused by your test setup if it’s calling window.close().

A simple jest.spyOn(window, "close").mockImplementation(jest.fn()); in the test setup could possibly fix the issue.

Also, you may want to check if jsdom dependencies are up to date.

github.com/jsdom/jsdom

TypeError: Cannot read property '_location' of null

opened 07:25PM - 22 Jan 18 UTC

closed 11:01AM - 01 Oct 22 UTC

legraphista

### Basic info: - **Node.js version:** v8.9.1 - **jsdom version:** 11.6.0 … ### Minimal reproduction case When there is a network request, if the window is closed after the message is sent but before the message is received, the code will continue to run and any window access will result in this kind of error: ```js (node:15703) TypeError: Cannot read property '_location' of null at Window.get location [as location] (/Users/Stefan/Desktop/Work/html-render/node_modules/jsdom/lib/jsdom/browser/Window.js:188:79) at fetch.then.then (./script.js:2:10) at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) ``` In this example I polyfill fetch and make a request from an external script. As soon as the window loads I close it. *main.js* ```js const jsdom = require("jsdom"); const { JSDOM } = jsdom; const window = (new JSDOM(`<html> <head></head> <body> <script src="./script.js"></script> </body> </html>`, { runScripts: "dangerously", resources: 'usable', })).window; window.fetch = require('node-fetch'); window.onload = () => { window.close(); }; ``` *script.js* ```js fetch('https://api.ipify.org').then(x => x.text()).then((ip) => { window.location.href = ip; }); ``` ### How does similar code behave in browsers? Window closes and any network request is aborted. Since fetch in this case is an external implementation and uses node's I/O callback, i'm not sure how that callback can be stopped.

adonis17 · September 11, 2023, 3:29pm

Thank you so much for this info!